search

graphile / crystal

🔮 Graphile's Crystal Monorepo; home to Grafast, PostGraphile, pg-introspection, pg-sql2 and much more!
https://graphile.org/
Other
12.62k stars 571 forks source link

[draft] fix: constraints unit test #2225

Closed aryascripts closed 2 weeks ago

aryascripts commented 2 weeks ago

Description

This is only an example to explain the issue in #2226

Screenshot 2024-11-01 at 3 04 48 PM

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: cc5078d6ad5dd4af5e2d7b065a2d7e48c667051f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

benjie commented 2 weeks ago

I appreciate your work on this, but before changing the behavior of constraint matching I'd like to know what it is that's causing this constraint to exist in the first place, because whatever code that is, is likely wrong. See this comment for more context:

https://github.com/graphile/crystal/issues/2226#issuecomment-2454199650

benjie commented 2 weeks ago

Seems the underlying issue was already solved by #2129