Support for specifying Node ID relations as `condition` inputs

graphile / global-ids

[EXPERIMENTAL] Allows you to use Relay global object identifiers in more places.

MIT License

9 stars 1 forks source link

Support for specifying Node ID relations as `condition` inputs #8

Open marshall007 opened 5 years ago

marshall007 commented 5 years ago

TODO

[x] add tests

Future Work

[ ] refactor into separate plugins
[x] handle null case on NodeID conditions
[ ] properly error when the specified NodeID is invalid
- [ ] wrong table type
- [ ] mismatch between non-NodeID conditions

marshall007 commented 5 years ago

@benjie I've added tests, please review again when you have a chance. I think I'm gonna leave any further refactoring (splitting into multiple plugins) for a later time. We have a need for these changes in our current project so I'd just like to get it merged ASAP.

marshall007 commented 5 years ago

@benjie I have opened up a separate PR to this branch which converts the new condition inputs to array arguments. The desire for this popped up basically immediately once we started using it.

Need help understanding why the updated test is failing on that branch with GraphQLError: Cannot read property 'fragment' of undefined.

marshall007 commented 5 years ago

Fixed the failing test and merged that PR. Just need to make sure array NodeID condition args seem like a sane default default to you @benjie.