Closed kevinmamaqi closed 3 years ago
I don’t understand why this is necessary; tslib is an explicit dependency of PostGraphile: https://github.com/graphile/postgraphile/blob/main/package.json#L78
Will have to investigate.
Hi @benjie,
I received an error related with the plugin due to the tslib missing. I had to install it to make it work.
Sorry @kevinmamaqi I was on my phone so didn't reply in enough detail; what I mean is that this shouldn't be necessary. That it is indicates something is going wrong - so thanks for bringing the issue to my attention and I will try and figure out what's going wrong and address it within the packages themselves :+1:
Turns out this is a dependency bug in postgraphile-plugin-connection-filter that only seems to surface when the packages are installed globally (npm install -g
) because tslib
is not hoisted from PostGraphile in this case and thus the dependencies are not shared. I've filed an issue about it:
https://github.com/graphile-contrib/postgraphile-plugin-connection-filter/issues/164
Thanks for making me aware of the issue :pray:
This issue is now resolved: https://github.com/graphile-contrib/postgraphile-plugin-connection-filter/issues/164 👍
Include tslib as it throws an error if not installed.
Description
Performance impact
Security impact
Checklist
yarn lint:fix
passes.yarn test
passes.RELEASE_NOTES.md
file (if one exists).