graphile / migrate

Opinionated SQL-powered productive roll-forward migration tool for PostgreSQL.
MIT License
751 stars 58 forks source link

clobbers placeholders without warning #77

Closed purge closed 4 years ago

purge commented 4 years ago

While this behaviour is documented, if you define DATABASE_OWNER or DATABASE_NAME as placeholders graphile-migrate should warn that it is going to overwrite them, otherwise it can lead to some unexpected behaviour.

benjie commented 4 years ago

Indeed, I think it should check to see if the envvars are set; and if so, if they differ it should throw an error.