fix: quoting in docker yarn setup

graphile / starter

Opinionated SaaS quick-start with pre-built user account and organization system for full-stack application development in React, Node.js, GraphQL and PostgreSQL. Powered by PostGraphile, TypeScript, Apollo Client, Graphile Worker, Graphile Migrate, GraphQL Code Generator, Ant Design and Next.js

https://graphile-starter.herokuapp.com

Other

1.74k stars 219 forks source link

fix: quoting in docker yarn setup #279

Closed DanielFGray closed 2 years ago

DanielFGray commented 2 years ago

Description

fixes quoting in docker .env file for docker-compose v2, issue #278

Performance impact

unknown

Security impact

unknown

Checklist

[x] My code matches the project's code style and yarn lint:fix passes.
[x] I've added tests for the new feature, and yarn test passes.
[x] I have detailed the new feature in the relevant documentation.
[ ] I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
[x] If this is a breaking change I've explained why.

benjie commented 2 years ago

Will this still work with compose v1? Are double quotes an option? They'd be preferred in this context, I feel.

DanielFGray commented 2 years ago

Will this still work with compose v1?

I havent figured out how to downgrade docker-compose on my system and test it myself, but I feel fairly confident it would

Are double quotes an option?

My understanding of yaml is that they are interchangeable, a quick test on my machine doesn't yield any noticeable difference.