graphile / starter

Opinionated SaaS quick-start with pre-built user account and organization system for full-stack application development in React, Node.js, GraphQL and PostgreSQL. Powered by PostGraphile, TypeScript, Apollo Client, Graphile Worker, Graphile Migrate, GraphQL Code Generator, Ant Design and Next.js
https://graphile-starter.herokuapp.com
Other
1.75k stars 219 forks source link

Update yarn-setup.js to also set group #352

Closed triptec closed 1 year ago

triptec commented 1 year ago

When fixing the permissions of node_modules mounted from docker volumes also set the group to node. This does not fix a bug, it works just as it is, but it looks strange especially when debugging and one is looking into every possible problem =).

I also updated the comment around it as at first I could not understand why it would be needed in the first place as I thought the dirs would be owned by node if the node_modules dirs were created by yarn run by the node user.

Description

Performance impact

Security impact

Checklist