search

graphistry / falcor

Graphistry forks of the FalcorJS family of projects in a lerna-powered mono-repo.
23 stars 3 forks source link

Breaking api change regarding paths on getValue #5

Closed drFabio closed 7 years ago

drFabio commented 7 years ago

getValue is not parsing a path here https://github.com/graphistry/falcor/blob/master/packages/falcor/lib/get/getValue.js#L5

While on Netflix falcor it accepts an unparsed path https://github.com/Netflix/falcor/blob/master/lib/get/getValue.js#L5. Was this an intentional api change?

trxcllnt commented 7 years ago

@drFabio yes, per the readme in the falcor-client project, the path-syntax was removed from the core dist to cut down on compilation size and speed. If you're using Rx, the companion falcor-model-rxjs project does automatically run arguments through the path syntax parser.

That said, we use the alternate falcor-query-syntax in conjunction with the Model's new recycleJSON option, which uses the query-syntax AST to optimize cache searches by comparing hash codes between the get request and the Model's deref'd JSON node.

drFabio commented 7 years ago

Ok. Just wanted to know if that was intentional. Thanks for the response!