graphistry / falcor

Graphistry forks of the FalcorJS family of projects in a lerna-powered mono-repo.
23 stars 2 forks source link

falcor-router wrong path resolution. #7

Closed drFabio closed 7 years ago

drFabio commented 7 years ago

Handling a path with the form of:

"foo.WHATEVER"{
  call(pathSet, args) {
    return [
        {
          "path": [
            "bar",
            "baz"
          ],
          "value": 1
        },
        {
          "path": [
            "foo",
            "zap",
            0
          ],
          "value": 2
        }
    ]
  }
}

The resullting jsonGraph will be:

{
  foo: {
    "bar":{
      "baz":1 //WRONG
    },
    "zap":{
      0:2
    }
  }
}

While on falcor-router the same response has the correct structure

{
  "bar":{
    "baz":1 
  foo: {
    "zap":{
      0:2
    }
  }
}

The first path is concatenated with the root (thisPath) of the call path, the remaining paths goes unchanged

trxcllnt commented 7 years ago

@drFabio Sorry for the delay, I didn't have notifications on for the project :/. This should be fixed in the latest published version of the Router.

drFabio commented 7 years ago

No worries. Thanks for the response