search

graphistry / graph-app-kit

Go from graph data to a secure and interactive visual graph app in 15 minutes. Batteries-included self-hosting of graph data apps with Streamlit, Graphistry, RAPIDS, and more!
BSD 3-Clause "New" or "Revised" License
200 stars 23 forks source link

Fixed all references to the old docker-compose command to use newer 'docker compose' #95

Closed rjurney closed 1 year ago

rjurney commented 1 year ago

94 kept dc up from working. This PR fixes the issue.

lmeyerov commented 1 year ago

The are some automation scripts in this repo that launch images that likely don't have the docker compose plugin, just the docker-compose command, so we should probably wait on this PR as part of a broader upgrade? Or to land sooner, do some sort of availability check?

rjurney commented 1 year ago

I see now that this is only a partial fix for the src/docker folder and the rest of the repo has a lot of docker-compose instances. What if we did an environment / version specific alias in the build as part of a fix here when we do the entire repo, such as:

alias "docker-compose"="docker compose"

That way the old command will work if the build expects it, otherwise it won't? We could detect the docker-ce version.

lmeyerov commented 1 year ago

maybe reuse what we have elsewhere as a stop gap: https://github.com/graphistry/graphistry/blob/9a93d7c90346b8cf35e16468ce8774645e0b16dd/compose/etc/scripts/migrate.sh#L159