Numeric layout props not appearing -- undefined handling?

lmeyerov commented 2 years ago

Ex:

https://github.com/graphistry/graphbi/blob/b904fff0f824f0e478dd5ebd2258c7374bff10af/pbiviz/capabilities.json#L356

Some reason the bool properties are showing up and impacting layout, but numeric properties are not showing up in the panel and thus not impacting layout, ex, gravity ( https://github.com/graphistry/graphbi/search?q=gravity : strength of center of gravity in middle of screen ~= blackhole vortex)

config.LayoutGravity = this.visualSettings.layoutSetting.gravity;
but some reason not showing up in the powerbi panel either
in this particular case, also, gravity missing in extraOpts at https://github.com/graphistry/graphbi/blob/704be2eedb92ec1039acffcf013f66f525514cfd/pbiviz/src/components/Graphistry.tsx#L37
should appear in the url of the generated visualization as &gravity=...

vs

lmeyerov commented 2 years ago

Not sure if still happening or was fixed?

Not super important right now, but once we add tree etc. layouts, will matter more

dess890 commented 2 years ago

numeric props can't have undefined-- either null or value/range

graphistry / graphbi

Numeric layout props not appearing -- undefined handling? #29