table names in fields is confusing labels

graphistry / graphbi

Graphistry monorepo for BI integrations

0 stars 0 forks source link

table names in fields is confusing labels #41

Closed lmeyerov closed 2 years ago

lmeyerov commented 2 years ago

table names passed from powerbi are showing up as overly-long field names

maybe a toggle for whether to strip?
strip in some areas but not others?

lmeyerov commented 2 years ago

Maybe:

[x] strip by default
[x] ... except where there is overlap

lmeyerov commented 2 years ago

` Screenshot from 2022-05-17 12-15-17

Ex: In edge property "Business Units.Region" = "Glennie Butters", we should trim the edge property to just "Region", as long as no other edge property has name Region (ex: no conflicting "Department.Region")

lmeyerov commented 2 years ago

left-hand side of: https://github.com/graphistry/graphbi/blob/4d3f827967908c985b855b90f13cfa6e2b358264/pbiviz/src/visual.ts#L184

lmeyerov commented 2 years ago

src/dst/weight, e.g.,: https://github.com/graphistry/graphbi/blob/4d3f827967908c985b855b90f13cfa6e2b358264/pbiviz/src/visual.ts#L178

... but must also update uploaded bindings correspondingly, e.g., https://github.com/graphistry/graphbi/blob/4d3f827967908c985b855b90f13cfa6e2b358264/pbiviz/src/visual.ts#L250

lmeyerov commented 2 years ago

@dess890 was there a PR for this? thanks!