Open lmeyerov opened 1 year ago
Bugs are:
When you inject a selection it causes a bunch of events, as many as 10.
When you inject a selection, the onSelectionUpdate can have the wrong selection.labels
hovering over the nodes to get thier label causes the above to fix it also causes the onSelection to flicker
These didn't reproduce for me with ./nc
What does "hovering over the nodes to get thier label causes the above to fix it" mean? That the wrong label is shown, and hovering triggers an update that will show the correct one? I wonder if that means we're properly invalidating the label cache, but not subscribing to the invalidations properly in the labels container / triggering the wrong rendering effects for the rendering scheduler?
I was actually more worried about filter states messing up local vs global indexing, so the above feels more doable :)
@exrhizo I lost track, can you share status here?
(I think this one is paused pending Gadi's feedback)
Enable embedding users to trigger fast highlights & selections of items
Ex:
Out-of-scope: Prototype will -
Piggybacks on selection API work