graphistry / graphistry-js

API for controlling and reacting to embedded visualizations
Apache License 2.0
33 stars 6 forks source link

cleanup: Docker compat m1, dep updates, script fix #116

Closed exrhizo closed 1 year ago

exrhizo commented 1 year ago

Updated docs

Updated deps for client-api and client-api-react and cra-test and lerna

Small bugfix in extract-dist.sh

exrhizo commented 1 year ago

@lmeyerov there is an issue with my release to npm where the client-api-react doesn't import because of an issue with how I did the release and the dist folder for that package, so I want to merge these and make a new minor revision.

exrhizo commented 1 year ago

The reason python is needed for ./dc build is this error

#0 4.387 npm ERR! path /opt/graphistry-js/node_modules/@parcel/watcher
#0 4.388 npm ERR! command failed
#0 4.388 npm ERR! command sh -c node-gyp-build
#0 4.388 npm ERR! gyp info it worked if it ends with ok
#0 4.388 npm ERR! gyp info using node-gyp@9.3.1
#0 4.388 npm ERR! gyp info using node@16.13.0 | linux | arm64
#0 4.388 npm ERR! gyp ERR! find Python 
#0 4.388 npm ERR! gyp ERR! find Python Python is not set from command line or npm configuration

@parcel/watcher is a dep of lernas

npm explain @parcel/watcher
@parcel/watcher@2.0.4 dev
node_modules/@parcel/watcher
  @parcel/watcher@"2.0.4" from nx@15.8.6
  node_modules/nx
    nx@"15.8.6" from @nrwl/cli@15.8.6
    node_modules/@nrwl/cli
      @nrwl/cli@"15.8.6" from nx@15.8.6
    peer nx@">= 14.1 <= 16" from @nrwl/devkit@15.8.6
    node_modules/@nrwl/devkit
      @nrwl/devkit@">=15.5.2 < 16" from lerna@6.5.1
      node_modules/lerna
        dev lerna@"^6.5.1" from the root project
    nx@"15.8.6" from @nrwl/tao@15.8.6
    node_modules/@nrwl/tao
      @nrwl/tao@"15.8.6" from nx@15.8.6
    nx@">=15.5.2 < 16" from lerna@6.5.1
    node_modules/lerna
      dev lerna@"^6.5.1" from the root project

I don't understand why building on with m1 would cause the docker image to build without python, but anyway I will revert these changes for that part of this PR