search

graphite-project / carbon

Carbon is one of the components of Graphite, and is responsible for receiving metrics over the network and writing them down to disk using a storage backend.
http://graphite.readthedocs.org/
Apache License 2.0
1.5k stars 490 forks source link

Add s390x support for travis #869

Closed sangitanalkar closed 4 years ago

sangitanalkar commented 4 years ago

As Travis CI officially supports s390x builds, adding support for same.

piotr1212 commented 4 years ago

Not against, but is there actually anyone who will fix s390 issues if they would occur?

Is it needed to duplicate all entries? Wouldn't just adding an "arch:" entry work like described here.

sangitanalkar commented 4 years ago

Hi,

Yes, we already build and maintain carbon on s390x. Our build instructions are published here .

Regarding "Is it needed to duplicate all entries? ", if we just add "arch: " entry, only 3 travis builds are triggered for s390x for the 3 environments mentioned at " https://github.com/graphite-project/carbon/blob/master/.travis.yml#L34 " and the ones in the matrix are not triggered. Hence added it separately.

sangitanalkar commented 4 years ago

Hi, any updates on the PR if the changes can be merged?