search

graphite-project / carbon

Carbon is one of the components of Graphite, and is responsible for receiving metrics over the network and writing them down to disk using a storage backend.
http://graphite.readthedocs.org/
Apache License 2.0
1.5k stars 490 forks source link

Fix missing encoding for line protocol #885

Closed pkruk closed 4 years ago

pkruk commented 4 years ago

PR for issue: https://github.com/graphite-project/carbon/issues/884

piotr1212 commented 4 years ago

Thanks this should work but the tests need to be adjusted, see the travis results. You can ignore the deepsource results. There is also a trailing whitespace which breaks the lint check.

to run the tests locally just invoke tox.

deniszh commented 4 years ago

I disable Deepsource, maybe will remove it completely.

pkruk commented 4 years ago

@piotr1212 thanks! I fixed this trailing whitespace

piotr1212 commented 4 years ago

tests are still failing, you can replace the expected values with the actual ones (just add the b in front of the string to indicate it is a bytearray)

pkruk commented 4 years ago

@piotr1212 Hey, I will fix it in a moment :) thanks!