search

graphite-project / carbon

Carbon is one of the components of Graphite, and is responsible for receiving metrics over the network and writing them down to disk using a storage backend.
http://graphite.readthedocs.org/
Apache License 2.0
1.5k stars 490 forks source link

Add skipcq: PTC-W0034 #894

Closed jsoref closed 4 years ago

jsoref commented 4 years ago

https://deepsource.io/gh/graphite-project/carbon/run/f7c9db6c-4530-4b82-8ae7-57850da0e1e0/python/PTC-W0034

deniszh commented 4 years ago

@jsoref FYI, lint check is broken now:

lib/carbon/util.py:235:32: E261 at least two spaces before inline comment
lib/carbon/util.py:235:33: E262 inline comment should start with '# '
lib/carbon/util.py:257:32: E261 at least two spaces before inline comment
lib/carbon/util.py:257:33: E262 inline comment should start with '# '
codecov-io commented 4 years ago

Codecov Report

Merging #894 into master will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #894   +/-   ##
=======================================
  Coverage   51.53%   51.53%           
=======================================
  Files          36       36           
  Lines        3450     3450           
  Branches      495      495           
=======================================
  Hits         1778     1778           
  Misses       1555     1555           
  Partials      117      117
Impacted Files Coverage Δ
lib/carbon/util.py 49.48% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e4571ff...7ece7f5. Read the comment docs.

jsoref commented 4 years ago

Fwiw, I make no warranty about this being the right thing to do in general, it's just to silence the warnings as reported for #893