search

graphite-project / carbon

Carbon is one of the components of Graphite, and is responsible for receiving metrics over the network and writing them down to disk using a storage backend.
http://graphite.readthedocs.org/
Apache License 2.0
1.5k stars 490 forks source link

Remove unused args #905 #911

Closed pkruk closed 3 years ago

pkruk commented 3 years ago

Like in this issue: https://github.com/graphite-project/carbon/issues/905

I runned tests, tox and looks fine :)

piotr1212 commented 3 years ago

These are callback functions, did you check if they are not called with argument from the reactor? And this code is not covered by unittests, unfortunately passing tests don't say much. You can check test coverage by running coverage html, it then generate an html report in the htmlcov directory.

deniszh commented 3 years ago

Yes, what @piotr1212 said. I would not touch callback functions without very important reason.

pkruk commented 3 years ago

you're right, then i will drop the changes which touch a callback functions :)

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.