[1.1.x] remove carbon-client.py, is broken for 4 years (1ebd4c16) | Add skipcq: PTC-W0034 (7ece7f57) | Spelling (#893) | Update storage-aggregation.conf.example (41af02c3) | add config option to turn off logging of lost connections (f90516d

[deniszh]

Backports the following commits to 1.1.x:

• remove carbon-client.py, is broken for 4 years (1ebd4c16)
• Add skipcq: PTC-W0034 (7ece7f57)
• Spelling (#893)
• Update storage-aggregation.conf.example (41af02c3)
• add config option to turn off logging of lost connections (f90516db)
• change default value to False (6e69af5e)
• update conf example values to False (26719e97)
• Provide more complete list of aggregation options (8e701f5f)
• gitignore (1d3e026b)
• Replacing pyCrypto with pyca/cryptography for tests (632ffc44)
• skippinmg test_enable_tcp_keep_alive on macos (0f3236a5)
• Adding SKIP_TAGS_FOR_NONTAGGED, disabled by default (86dba756)
• Enabling SKIP_TAGS_FOR_NONTAGGED by default (374d465a)
• Fixing lint, adding pypy3 (a901c24d)
• Fixes #906 (BAN-B101) Assert statement used outside of tests (d56e6e69)
• Update storage.py (dd99b6b3)
• Update storage.py (f0732e9f)
• Fixes #908 (PTC-W0016) Unnecessary comprehension (#909)
• Update hashing.py (cfd0605d)
• Removed assertion check. Tests pass (c55758d7)
• Adding CodeQL analysys (57e4d3d9)
• Switching x86 arch tests to Github Actions (0a62da40)
• Let's try simple (6d44198e)
• Rearranging code a bit (e6ab4dc0)

[lgtm-com[bot]]

This pull request fixes 2 alerts when merging 138f38aeb013f8c95b10ec0de73a8a7f43300998 into 56250f52195412e4e0c27e1a919217d540ee216d - view on LGTM.com

fixed alerts:

• 1 for Unused import
• 1 for Wrong name for an argument in a class instantiation

[codecov-io]

Codecov Report

Merging #918 (d6efe1e) into 1.1.x (56250f5) will increase coverage by 1.35%. The diff coverage is 7.14%.

:exclamation: Current head d6efe1e differs from pull request most recent head d350e87. Consider uploading reports for the commit d350e87 to get more accurate results

@@            Coverage Diff             @@
##            1.1.x     #918      +/-   ##
==========================================
+ Coverage   50.01%   51.37%   +1.35%     
==========================================
  Files          37       36       -1     
  Lines        3517     3430      -87     
  Branches      503      495       -8     
==========================================
+ Hits         1759     1762       +3     
+ Misses       1642     1551      -91     
- Partials      116      117       +1     

Impacted Files	Coverage Δ
lib/carbon/aggregator/buffers.py	93.67% <0.00%> (ø)
lib/carbon/client.py	56.44% <ø> (+0.93%)	:arrow_up:
lib/carbon/conf.py	38.43% <ø> (ø)
lib/carbon/hashing.py	90.42% <ø> (-0.11%)	:arrow_down:
lib/carbon/instrumentation.py	28.36% <ø> (ø)
lib/carbon/protocols.py	73.47% <0.00%> (-0.33%)	:arrow_down:
lib/carbon/storage.py	69.52% <0.00%> (-3.30%)	:arrow_down:
lib/carbon/writer.py	0.00% <0.00%> (ø)
lib/carbon/util.py	50.17% <33.33%> (+0.68%)	:arrow_up:
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56250f5...d350e87. Read the comment docs.

[lgtm-com[bot]]

This pull request fixes 2 alerts when merging d6efe1ed0c0bf01d5f1f209f1f89ea21f489d5f1 into 56250f52195412e4e0c27e1a919217d540ee216d - view on LGTM.com

fixed alerts:

• 1 for Unused import
• 1 for Wrong name for an argument in a class instantiation

[lgtm-com[bot]]

This pull request fixes 2 alerts when merging d350e8761e72acef346b484a30dfab9b51c300dc into 56250f52195412e4e0c27e1a919217d540ee216d - view on LGTM.com

fixed alerts:

• 1 for Unused import
• 1 for Wrong name for an argument in a class instantiation