search

graphite-project / carbon

Carbon is one of the components of Graphite, and is responsible for receiving metrics over the network and writing them down to disk using a storage backend.
http://graphite.readthedocs.org/
Apache License 2.0
1.51k stars 490 forks source link

Python 3.9.6 causes warning about buffering for binary mode #922

Open wvolz opened 3 years ago

wvolz commented 3 years ago

Running Carbon 1.1.8 is causing a warning when starting up under Python 3.9.6:

lib/python3.9/os.py:1023: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used

I believe the issue is caused by the "1" on this line: https://github.com/graphite-project/carbon/blob/9fad18df5731271aab6f5c81d32eddcecdc1a695/lib/carbon/log.py#L24

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

deniszh commented 3 years ago

Should be addressed

JohnHay commented 3 years ago

I also see it on FreeBSD with python 3.8.12:

Starting carbon.
Starting carbon-cache (instance a)
/usr/local/lib/python3.8/os.py:1023: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used
  return io.open(fd, *args, **kwargs)
stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

RedShiba commented 5 months ago

catching the same issue