search

graphite-project / carbon

Carbon is one of the components of Graphite, and is responsible for receiving metrics over the network and writing them down to disk using a storage backend.
http://graphite.readthedocs.org/
Apache License 2.0
1.5k stars 490 forks source link

Don't use git protocol for dependency #929

Closed tomdcc closed 2 years ago

tomdcc commented 2 years ago

Unauthenticated git access has been disabled by Github. This dependency causes carbon to fail during installation in many environments, e.g. docker containers with no other authentication set up.


#13 2.527 Collecting whisper |  
-- | --
  | #13 2.528   Cloning git://github.com/graphite-project/whisper.git to /tmp/pip-install-wz3idsrz/whisper_7e23b2a5d1834eaebec6a22002e118ce |  
  | #13 2.531   Running command git clone --filter=blob:none --quiet git://github.com/graphite-project/whisper.git /tmp/pip-install-wz3idsrz/whisper_7e23b2a5d1834eaebec6a22002e118ce |  
  | #13 3.105   fatal: remote error: |  
  | #13 3.105     The unauthenticated git protocol on port 9418 is no longer supported.

Switching to HTTP should be issue-free, and matches the dependency in the graphite-web project.

tomdcc commented 2 years ago

It would also be nice if either the latest release tag were updated with this, or a new release is issued.

deniszh commented 2 years ago

@tomdcc : Yes, I thought I removed it everywhere. Thanks!

deniszh commented 2 years ago

Looks like tests-requirements.txt also should be fixed...