Change Black/White List to Block/Allow list

graphite-project / carbon

Carbon is one of the components of Graphite, and is responsible for receiving metrics over the network and writing them down to disk using a storage backend.

http://graphite.readthedocs.org/

Apache License 2.0

1.5k stars 490 forks source link

Change Black/White List to Block/Allow list #939

Open jaimegago opened 1 year ago

jaimegago commented 1 year ago

I know the etymology of blacklist/whitelist has nothing to do with racism, yet it adds another stone to the "black is bad/white is good" edifice. So why not change it since we can, it's fairly simple and it doesn't cost anyone anything but to change a technical name? Also quite frankly as far as software engineering naming goes, Block/Allow are quite better at carrying the meaning of what that code does than Black/White aren't they ;-).

deniszh commented 1 year ago

Related PRs - https://github.com/graphite-project/graphite-web/pull/1700/ and https://github.com/graphite-project/carbon/pull/591 , probably they can be rebased on latest codebase and merged.

jaimegago commented 1 year ago

Ah! The change is ready to go, nice!

deniszh commented 1 year ago

well, not exactly, it's from 2016, will require some work

deniszh commented 1 year ago

Ok, I created https://github.com/graphite-project/graphite-web/pull/2808 and https://github.com/graphite-project/carbon/pull/943 and tried to rebase / fixed tests, but looks like it's require much more work then I anticipated. :( So, unfortunately, parking this for now, maybe someone else can contribute or I'll find time bit later. Thanks for understanding!