search

graphite-project / carbonate

Utilities for managing graphite clusters
MIT License
516 stars 80 forks source link

Changed mutable default argument in test_fill.py and test_sync.py #126

Closed aastha12 closed 3 years ago

codecov-commenter commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5af8a3b). Click here to learn what that means. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #126   +/-   ##
=========================================
  Coverage          ?   82.27%           
=========================================
  Files             ?       18           
  Lines             ?      784           
  Branches          ?        0           
=========================================
  Hits              ?      645           
  Misses            ?      139           
  Partials          ?        0
Impacted Files Coverage Δ
tests/test_fill.py 93.57% <66.66%> (ø)
tests/test_sync.py 91.42% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5af8a3b...bd3f074. Read the comment docs.

piotr1212 commented 3 years ago

Why would you change this?

aastha12 commented 3 years ago

We shouldn't use a mutable like list as a default value to an argument. Link

deniszh commented 3 years ago

it's harmless enough to merge IMO