search

graphite-project / carbonate

Utilities for managing graphite clusters
MIT License
516 stars 80 forks source link

Fix default node argument for sieve #31

Closed kamaradclimber closed 10 years ago

kamaradclimber commented 10 years ago

When --node is not specified, self was set instead of None it prevent the code from using local_addresses

jssjr commented 10 years ago

Thanks for this. Can you give me an example of how to reproduce this or add a test?

kamaradclimber commented 10 years ago

use carbon-sieve without specifiying any argument:

for instance:

carbon-list | carbon-sieve -I

will report every metric list on the server

carbon-list | carbon-sieve -I -n [IPADDRESS]

should report (in normal cases) nothing

jssjr commented 10 years ago

I'm showing normal behavior over here. Working on a test case to demonstrate as well. 

jssjr@metrics-carbon1-cp1-prd:~$ carbon-list | wc -l
2667259
jssjr@metrics-carbon1-cp1-prd:~$ carbon-list | carbon-sieve -I | wc -l
209060
jssjr@metrics-carbon1-cp1-prd:~$ carbon-list | carbon-sieve -I -n 172.16.9.13 | wc -l
209060

What version of python and carbon/whisper/etc?

jssjr commented 10 years ago

Aha! I see exactly what you're saying now. Please ignore my previous comment. I'm running a dev branch that had already incorporated https://github.com/jssjr/carbonate/commit/12e6679f26586799367e4b88d72e8d9b325b3ecd. Let me adjust the tests so they fail with no node provided and we'll get this merged!