graphite-project / carbonate

Utilities for managing graphite clusters
MIT License
516 stars 80 forks source link

support other consistent hashing algorithms ? #43

Closed filippog closed 4 years ago

filippog commented 9 years ago

hi, as pointed out in the README ports and "labels" are not taken into consideration when running the consistent hashing algo (as #38 found out too) I think it'd make sense to support other hashing implementations, e.g. fnv1a would make carbonate compatible with https://github.com/grobian/carbon-c-relay which in turn would allow hashing ip+port, what do you think?

jssjr commented 9 years ago

I'd be happy to field a PR to make the hash algorithm pluggable. This isn't something I personally have a use case for, but it does seem really handy.

halcyonardency commented 8 years ago

This would be super awesome to support fnv1a_32 and fnv1a_64 out of carbon-c-relay.

https://github.com/grobian/carbon-c-relay/blob/master/fnv1a.h

halcyonardency commented 8 years ago

I think I can probably git a PR submitted. There's a few examples online.

I'll find some cycles in the next week or two and see if we can't make this happen.

deniszh commented 8 years ago

@xyntrix - did you succeed in that PR by any chance? I want to do that same :)

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.