search

graphite-project / carbonate

Utilities for managing graphite clusters
MIT License
516 stars 80 forks source link

option to use whisper.LOCK during sync/fill #47

Closed filippog closed 8 years ago

filippog commented 9 years ago

splitting this issue from #19 since they are really two different things

carbonate should use whisper.LOCK if it can during sync/fill like carbon does to prevent corrupting whisper files if multiple writers are present (e.g. carbon-cache and carbonate)

filippog commented 9 years ago

hi @jssjr ! thoughts/comments on this? I think it'd be great to have at least for safe operation. I think it should be smarter and retry on lock failure or keep a queue of retries, if the file exists chances are we are going to backfill data and thus can wait for e.g. carbon-cache

deniszh commented 8 years ago

Implemented in https://github.com/graphite-project/carbonate/pull/71