search

graphite-project / carbonate

Utilities for managing graphite clusters
MIT License
516 stars 80 forks source link

lock whisper files during carbon-sync and whisper-fill #48

Closed filippog closed 8 years ago

filippog commented 9 years ago

as discussed on #47, the option isn't symmetric between sync and fill (config file vs command line) however fill doesn't take a config file anyway. Also I noticed whisper-fill is included in graphite's distribution too so that will need updating as well.

filippog commented 9 years ago

also note this is missing some prose about the new option and its implication when syncing running/live clusters, I can take a stab at that but I'm no native speakr, @jssjr you'd do a much better job I guess :)

filippog commented 9 years ago

updated to reflect latest master, thoughts?

filippog commented 9 years ago

@jssjr thoughts on this? I think it'd be important to have and avoid multiple writers corrupt whisper files

deniszh commented 8 years ago

Nah, maybe I nitpicking.

deniszh commented 8 years ago

Looks like more test need to be fixed

deniszh commented 8 years ago

Fixed in https://github.com/graphite-project/carbonate/pull/71