search

graphite-project / carbonate

Utilities for managing graphite clusters
MIT License
516 stars 80 forks source link

Adding LICENSE file to pypi package #97

Closed deniszh closed 6 years ago

deniszh commented 6 years ago

Fixing #96

koobs commented 6 years ago

@deniszh Thanks for this! It would be great if you could also add tests/*, tox.ini and requirements.txt, as setup.py doesn't yet use tests_require or document/implement running the tests (via test_suite, a test command or similar). This will help packagers run QA/tests downstream, hopefully resulting in additional feedback for yourself in the long term.

deniszh commented 6 years ago

I'm not sure that test data should be included in pip package that way, sorry. If you want to build a package from the source - you should do it from source. Or please elaborate your use case, maybe I'm missing something.

koobs commented 6 years ago

Including files via MANIFEST.in wont install them (not included in package_data), but will just include them in the sdist. sdists are as "from source" as repository sources are. Being able to QA sdists provided by upstreams via PyPI ensures quality of the entire upstream packaging pipeline can be tested, which benefits upstream projects as well as us.

deniszh commented 6 years ago

@koobs Could you please open a separate issue for that? I'll check what can be done. Thanks!