search

graphite-project / ceres

Distributable time-series database (not actively maintained)
Apache License 2.0
356 stars 79 forks source link

If serie don't have data for requested interval, result should have proper time step #26

Open Civil opened 9 years ago

Civil commented 9 years ago

https://github.com/vladimir-smirnov-sociomantic/ceres/commit/555f9746e62b3af29c762c038506075aa767c2e2

If you request metric without any usable slices (e.x. no data for a long time and everything was rolled up out of the disk, but metadata still there) - you'll have resulting list with timeStep = 1, which isn't that good (it'll require recalculation of this slice on later stages). With this patch, ceres will return slice with more proper time steps (will look for them in the config file or use default one, instead of '1').

Though in current form it depends on dkulikovskiy's branch, because this commit also improves his detection of unneeded slices.

iain-buclaw-sociomantic commented 7 years ago

Confirmed, however this would only apply if you request the data outside of graphite, as normally if a node does not hasDataForInterval() then graphite won't bother looking it up.