search

graphite-project / graphite-web

A highly scalable real-time graphing system
http://graphite.readthedocs.org/
Apache License 2.0
5.9k stars 1.26k forks source link

Consolidate `add` and `offset` functions #2669

Open Felixoid opened 3 years ago

Felixoid commented 3 years ago

Is your feature request related to a problem? Please describe. As I see and discuss with @dzhdanov, add and offset are pretty much the same functions with different descriptions and small implementation details.

Describe the solution you'd like One function should be an alias to another with only one implementation

Describe alternatives you've considered The alternative would be to leave it as it is, but now it doesn't look good, even from the documentation side: add vs offset

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Felixoid commented 1 year ago

Is it still the case?

deniszh commented 1 year ago

I think so. Pinned.