graphite-project / graphite-web

A highly scalable real-time graphing system
http://graphite.readthedocs.org/
Apache License 2.0
5.89k stars 1.26k forks source link

Depend on third-party scandir only for Python < 3.5 #2706

Closed neirbowj closed 3 years ago

neirbowj commented 3 years ago

Fixes #2705

codecov-commenter commented 3 years ago

Codecov Report

Merging #2706 (6592c28) into master (cd5bfdf) will decrease coverage by 0.58%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2706      +/-   ##
==========================================
- Coverage   80.17%   79.59%   -0.59%     
==========================================
  Files          88      176      +88     
  Lines        9446    18888    +9442     
  Branches     2005     4010    +2005     
==========================================
+ Hits         7573    15033    +7460     
- Misses       1584     3272    +1688     
- Partials      289      583     +294     
Impacted Files Coverage Δ
graphite/browser/urls.py 100.00% <0.00%> (ø)
graphite/urls.py 80.00% <0.00%> (ø)
graphite/render/attime.py 98.63% <0.00%> (ø)
graphite/dashboard/models.py 90.00% <0.00%> (ø)
graphite/http_pool.py 100.00% <0.00%> (ø)
graphite/render/views.py 70.00% <0.00%> (ø)
graphite/readers/utils.py 100.00% <0.00%> (ø)
graphite/settings.py 75.36% <0.00%> (ø)
graphite/storage.py 87.85% <0.00%> (ø)
graphite/account/urls.py 100.00% <0.00%> (ø)
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cd5bfdf...6592c28. Read the comment docs.

deniszh commented 3 years ago

Same as https://github.com/graphite-project/graphite-web/pull/2701 but looks more complete. Thanks!

deniszh commented 2 years ago

💔 Some backports could not be created

Status Branch Result
1.1.x Cherrypick failed because the selected commit was a merge commit. Please try again by specifying the parent with the mainline argument:

backport --mainline

or:

backport --mainline

Or refer to the git documentation for more information: https://git-scm.com/docs/git-cherry-pick#Documentation/git-cherry-pick.txt---mainlineparent-number|

To backport manually run: node scripts/backport --pr 2706. For more info read the Backport documentation