search

graphite-project / graphite-web

A highly scalable real-time graphing system
http://graphite.readthedocs.org/
Apache License 2.0
5.89k stars 1.26k forks source link

Fix dependency issue for usage as Grafana data source. #2722

Closed henkf closed 2 years ago

henkf commented 2 years ago

Pyparsing v3 was recently released, breaking compatibility of graphite-web for usage as Grafana data source. This was observed in Grafana v6.7.x and v8.0.3.

Until compatibility with pyparsing v3 is implemented, this change prevents breaking future deployments of graphite-web as grafana datasource.

henkf commented 2 years ago

I'd like to fix the failing checks if that's required for merging, but I can't make out a connection between the error messages and the small change in the requirements.txt. Can someone help me out here?

deniszh commented 2 years ago

I think you need to change dependencies in tox.ini too - in https://github.com/graphite-project/graphite-web/blob/master/tox.ini#L39 and https://github.com/graphite-project/graphite-web/blob/master/tox.ini#L62

henkf commented 2 years ago

Thanks!

deniszh commented 2 years ago

💔 Some backports could not be created

Status Branch Result
❌ 1.1.x Cherrypick failed because the selected commit was a merge commit. Please try again by specifying the parent with the mainline argument:

backport --mainline

or:

backport --mainline

Or refer to the git documentation for more information: https://git-scm.com/docs/git-cherry-pick#Documentation/git-cherry-pick.txt---mainlineparent-number|

To backport manually run: node scripts/backport --pr 2722. For more info read the Backport documentation