search

graphite-project / graphite-web

A highly scalable real-time graphing system
http://graphite.readthedocs.org/
Apache License 2.0
5.89k stars 1.26k forks source link

[BUG] AttributeError: 'ParseResults' object has no attribute 'raw' #2726

Closed tekbot closed 2 years ago

tekbot commented 2 years ago

Describe the bug grammar-unsafe.py is attempting to assign the attribute 'raw' without using indexed notation as required by pyparsing >= 3.0.4

To Reproduce With the versions of graphite-web and pyparsing listed below, attempt to use a basic function in either graphite composer, grafana, the API, etc.

Expected behavior Function is applied, data is rendered

Environment (please complete the following information):

Additional context This issue was raised a few days ago here. The accepted answer was to downgrade the pyparsing version, which likely won't work for everybody. Reading the pyparsing release notes here this was an intended change (though clearly not backwards compatible). Currently only downgrading to pyparsing==2.4.7 works after apache restart in both the webUI and grafana.

marcphilipp commented 2 years ago

Should this issue be closed given that #2727 has been merged?

marcphilipp commented 2 years ago

Is there a timeline for the 1.2.0 release? 😇

deniszh commented 2 years ago

1.1.9 Usually we have no timeline, cutting releases when it's enough changes happened. I'll try to find time to do release this week.

marcphilipp commented 2 years ago

@deniszh That would be awesome! I got 1.2.0 from the changelog.

deniszh commented 2 years ago

1.2.0 is current master, 1.1.x is current prod branch

deniszh commented 2 years ago

Fix will be released in 1.1.9 soon

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

lilydjwg commented 2 years ago

Please keep open. A fixed version is not released yet.

marcphilipp commented 2 years ago

Was this released as part of 1.1.10?

deniszh commented 2 years ago

Yes, it was

marcphilipp commented 2 years ago

Thanks for the confirmation! In that case this issue can be closed, right?

deniszh commented 2 years ago

Yes, you're totally right

rpygithub commented 2 years ago

We've consumed version 1.1.10 and can report that the fix works.