graphite-project / graphite-web

A highly scalable real-time graphing system
http://graphite.readthedocs.org/
Apache License 2.0
5.89k stars 1.26k forks source link

functions view: Replace ANOTHER instance of Infinity in JSON #2737

Closed bobemoe closed 2 years ago

bobemoe commented 2 years ago

This is a continuation of https://github.com/graphite-project/graphite-web/pull/2612 as it seems the target JSON may have changed structure slightly since the original patch was tested, meaning it misses replacing an instance of Infinity that comes last (does not have a trailing comma). This patch targets the trailing close brace also.

This patch fixes https://github.com/grafana/grafana/issues/45948

deniszh commented 2 years ago

Hi @bobemoe ,

Looks good, let me run tests and I will merge it.

codecov-commenter commented 2 years ago

Codecov Report

Merging #2737 (64bee58) into master (2105089) will decrease coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2737      +/-   ##
==========================================
- Coverage   76.29%   76.23%   -0.07%     
==========================================
  Files          88       88              
  Lines        9593     9593              
  Branches     2149     2149              
==========================================
- Hits         7319     7313       -6     
- Misses       2011     2014       +3     
- Partials      263      266       +3     
Impacted Files Coverage Δ
webapp/graphite/functions/views.py 95.12% <100.00%> (ø)
webapp/graphite/tags/redis.py 87.03% <0.00%> (-3.71%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2105089...64bee58. Read the comment docs.

deniszh commented 2 years ago

💚 All backports created successfully

Status Branch Result
1.1.x

Questions ?

Please refer to the Backport tool documentation