graphite-project / graphite-web

A highly scalable real-time graphing system
http://graphite.readthedocs.org/
Apache License 2.0
5.89k stars 1.26k forks source link

Introduce the term "node" #2793

Closed jbmilgrom closed 1 year ago

jbmilgrom commented 1 year ago

"Node" appears elsewhere throughout the documentation e.g. groupByNode. This PR adds a definition. I'm new to graphite and had to dig around to figure out what groupByNode meant - this definition I think would've been helpful.

codecov-commenter commented 1 year ago

Codecov Report

Base: 76.33% // Head: 76.31% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (9a5cf93) compared to base (02bc0c8). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2793 +/- ## ========================================== - Coverage 76.33% 76.31% -0.03% ========================================== Files 88 88 Lines 9672 9672 Branches 2062 2062 ========================================== - Hits 7383 7381 -2 - Misses 2021 2022 +1 - Partials 268 269 +1 ``` | [Impacted Files](https://codecov.io/gh/graphite-project/graphite-web/pull/2793?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphite-project) | Coverage Δ | | |---|---|---| | [webapp/graphite/tags/redis.py](https://codecov.io/gh/graphite-project/graphite-web/pull/2793/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphite-project#diff-d2ViYXBwL2dyYXBoaXRlL3RhZ3MvcmVkaXMucHk=) | `85.80% <0.00%> (-1.24%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphite-project). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=graphite-project)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

deniszh commented 1 year ago

Thanks for your contribution! Will merge it.

deniszh commented 1 year ago

💚 All backports created successfully

Status Branch Result
1.1.x

Questions ?

Please refer to the Backport tool documentation