search

graphiti-api / graphiti-rails

MIT License
54 stars 28 forks source link

Removed rails dependency from graphiti-rails #60

Closed mrhardikjoshi closed 4 years ago

mrhardikjoshi commented 4 years ago

Problem: Rails 5 is mentioned as a dependency in gemspec. This causes problem when graphiti-rails gem is used in projects where whole rails gem suit was not used.

example If some project is using mongoid or ActiveGraph then including graphiti-rails results in loading all of the Rails gem suit (ActiveRecord etc.) which are not needed actually.

Solution: Since graphiti-rails is dependant on 1) actionpack 2) activesupport and 3) railties. We can safely remove rails from gemspec and add railties in gemspec. railties includes actionpack and activesupport (Ref)

klobuczek commented 4 years ago

Hi @wagenet could you release the gem with this PR? Otherwise, we need to keep using our fork. Thanks.