search

graphiti-api / graphiti-rails

MIT License
54 stars 28 forks source link

Decide if auto-include is correct #7

Closed wagenet closed 5 years ago

wagenet commented 5 years ago

Right now we're auto-including Graphiti code in ActionController::Base source. This may be too aggressive.

First question is whether this has any potential downsides. If so, we should definitely let it be at least configurable. My inclination is to leave it for now and have us be less aggressive if people report issues.

wagenet commented 5 years ago

See also https://github.com/wagenet/graphiti-rails/issues/5#issuecomment-488724054 and https://github.com/wagenet/graphiti-rails/issues/5#issuecomment-488733910

richmolj commented 5 years ago

Mixin vs Railtie relevant to this one: https://github.com/wagenet/graphiti-rails/issues/10#issuecomment-490908327

wagenet commented 5 years ago

I think with rescue_registry (#22) this is fine.