search

graphiti-api / graphiti

Stylish Graph APIs
https://www.graphiti.dev/
MIT License
960 stars 138 forks source link

Remove the upper bound of the ruby version #394

Closed calebuharrison closed 2 years ago

calebuharrison commented 2 years ago

Also fixes specs that are currently failing.

richmolj commented 2 years ago

Hm, I think we need to add 3.x here for this, though I'm not sure why CI has stopped running on this PR

calebuharrison commented 2 years ago

Hm, I think we need to add 3.x here for this, though I'm not sure why CI has stopped running on this PR

Added!

richmolj commented 2 years ago

@wadetandy do you happen to know what happened to CI running on PRs?

smai-f commented 2 years ago

Hey @richmolj , I believe CI stopped running because an admin has to switch the project to travis-ci.com instead of travis-ci.org (you can see in the header here)

https://docs.travis-ci.com/user/migrate/open-source-repository-migration/

richmolj commented 2 years ago

@smai-f thanks so much - forgive me I'm short on time, where do I make the change?

smai-f commented 2 years ago

@richmolj AFAIK log in here and you should see a button to migrate this project to travis-ci.com, should be fast: https://travis-ci.org/account/repositories - if that doesn't work then I think you'd have to follow these instructions.

The only reference to travis-ci.org in the graphiti repo that would need to be updated after is line 1 of the README.

Last, if you use the Travis CLI or Travis CI API locally you'd need to make these changes. It does not appear these are used within graphiti.

richmolj commented 2 years ago

Unfortunately there is no button (there is a message) and the instructions point to https://www.travis-ci.com/account/migrate which is a 404 😬

smai-f commented 2 years ago

@richmolj Haha, classic. I suspect this might be the ticket then, starting from travis-ci.com instead of travis-ci.org - https://docs.travis-ci.com/user/migrate/open-source-repository-migration/#migrating-a-repository

richmolj commented 2 years ago

Screen Shot 2021-12-21 at 12 01 58 PM

ugh...

richmolj commented 2 years ago

Actually just bad UI bug. I have now successfully clicked migrate. Let me try close and reopen

richmolj commented 2 years ago

Not sure why it's not running...sorry im just trying things as I run xmas errands, @wadetandy do you know how to make it work?

richmolj commented 2 years ago

Aha there we go...

wagenet commented 2 years ago

I tried to get this working but it's been a challenge.

richmolj commented 2 years ago

Ugh thanks for the effort @wagenet, any suggestions on how we should proceed?

wagenet commented 2 years ago

@richmolj I’m splitting up some of the upgrades.

wagenet commented 2 years ago

This is good to go except for the fact that Travis doesn't support Ruby 3.1 still...

wagenet commented 2 years ago

Resolved in #406. Thanks!