search

graphiti-api / graphiti

Stylish Graph APIs
https://www.graphiti.dev/
MIT License
960 stars 138 forks source link

Prefer #update over #update_attributes #423

Closed jkeen closed 2 years ago

jkeen commented 2 years ago

Using/allowing @resource.update instead of @resource.update_attributes might help out a lot of rubocop + graphiti users, as Rubocop loves to think that @resource.update_attributes is out-of-date Rails code and will automatically change it to @resource.update which before this update broke things.

This keeps graphiti a little more in sync with the standard Railsy controller pattern

jkeen commented 2 years ago

Note: Base64 and Position related test failures are addressed in #422

richmolj commented 2 years ago

Thanks Jeff LGTM but could you give some context on the spec failures? Were they failing prior to this PR?

jkeen commented 2 years ago

@richmolj They were, they're actually failing in a bunch of the open PRs. It's completely unrelated to this change. While prepping this I noticed them and PR'd that fix early.

If you can approve and merge #422 a bunch of the failures will get resolved