Closed RasmusOrsoe closed 1 year ago
Hi Andreas
Seemingly, the SplineMPE is hard to beat. Only place I see it happening is in the last plot (azimuthal)… first three bins, the Baseline is better. Is this correctly understood?
Cheers, Troels
On 10 Jan 2023, at 15.31, Andreas Mosgaard Jørgensen @.***> wrote:
https://user-images.githubusercontent.com/72250101/211578331-f978e183-091b-4351-882b-866bdfa7baa6.png https://user-images.githubusercontent.com/72250101/211578369-35f17701-df4a-4e0e-b126-2cdae53da91b.png https://user-images.githubusercontent.com/72250101/211578386-8821f75d-bc1c-4d9c-bacb-8a3b6c49aee9.png https://user-images.githubusercontent.com/72250101/211578416-a3076ad0-32ed-4772-b12e-78353cc73a2a.png — Reply to this email directly, view it on GitHub https://github.com/graphnet-team/graphnet/issues/326#issuecomment-1377368176, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADLMFXNPTDZJRGGQMZLGW5LWRVXFBANCNFSM6AAAAAARO5YTVU. You are receiving this because you are subscribed to this thread.
@Andreas-MJ Thanks for this. Can you confirm that the dynedge-CosineLoss converged?
@Andreas-MJ Thanks for this. Can you confirm that the dynedge-CosineLoss converged?
Yes, it did converge
Hi Andreas Seemingly, the SplineMPE is hard to beat. Only place I see it happening is in the last plot (azimuthal)… first three bins, the Baseline is better. Is this correctly understood? Cheers, Troels … On 10 Jan 2023, at 15.31, Andreas Mosgaard Jørgensen @.***> wrote: https://user-images.githubusercontent.com/72250101/211578331-f978e183-091b-4351-882b-866bdfa7baa6.png https://user-images.githubusercontent.com/72250101/211578369-35f17701-df4a-4e0e-b126-2cdae53da91b.png https://user-images.githubusercontent.com/72250101/211578386-8821f75d-bc1c-4d9c-bacb-8a3b6c49aee9.png https://user-images.githubusercontent.com/72250101/211578416-a3076ad0-32ed-4772-b12e-78353cc73a2a.png — Reply to this email directly, view it on GitHub <#326 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADLMFXNPTDZJRGGQMZLGW5LWRVXFBANCNFSM6AAAAAARO5YTVU. You are receiving this because you are subscribed to this thread.
Exactly, however I don't see an obvious reason why is beats SplineMPE.
What is benchmarked Is there a difference in zenith and azimuthal performance, if we dynedge doesn't provide uncertainty estimations along with it's predictions?
Target variables used for evaluation zenith, azimuth
Step-by-step
LossFunction
called "CosineLoss
" whereloss = 1 - cos(ø) = 1 - cos(true_angle - prediction)
benchmark.py
with original settings, update the import statementfrom graphnet.models.task.reconstruction import ZenithReconstructionWithKappa, AzimuthReconstructionWithKappa
to
from graphnet.models.task.reconstruction import ZenithReconstructionWithKappa, AzimuthReconstructionWithKappa, PassOutput1
benchmark.py
, update the code that originally saidelif config["target"] == 'azimuth': task = AzimuthReconstructionWithKappa( hidden_size=gnn.nb_outputs, target_labels=config["target"], loss_function=VonMisesFisher2DLoss(), )
if config["target"] =='zenith': task = PassOutput1( hidden_size=gnn.nb_outputs, target_labels=config["target"], loss_function=CosineLoss(), )
elif config["target"] == 'azimuth': task = PassOutput1( hidden_size=gnn.nb_outputs, target_labels=config["target"], loss_function=CosineLoss(), )