graphnet-team / graphnet

A Deep learning library for neutrino telescopes
https://graphnet-team.github.io/graphnet/
Apache License 2.0
85 stars 86 forks source link

Update awtd and fadc parsing method #631

Closed RasmusOrsoe closed 8 months ago

RasmusOrsoe commented 8 months ago

Currently we extract the pulse variables fadc and awtd in I3FeatureExtractorIceCube86 like so:

output["awtd"].append((pulse.flags >> 1) & 0x1)  # bit 1
output["fadc"].append((pulse.flags >> 2) & 0x1)  # bit 2

However, recent studies by Tom Stuttard has shown this is inconsistent. This PR updates the parsing method of awtd to the new suggested method in the low energy oscillation working group. This method relies on the pulse width to identify pulses read out using the awtd digitizer. This means that the fadcbool is now defined as ~awtd. For this reason, the separate entry for fadc has been removed in this PR.

Aske-Rosted commented 8 months ago

Seems reasonable.