search

graphology / graphology

A robust & multipurpose Graph object for JavaScript & TypeScript.
https://graphology.github.io
MIT License
1.3k stars 86 forks source link

Fix graphology declaration file export #488

Closed shahzod-davlatov closed 1 year ago

shahzod-davlatov commented 1 year ago

Fixed this error:

There are types at 'my-project/node_modules/graphology/dist/graphology.d.ts', but this result could not be resolved when respecting package.json "exports". The 'graphology' library may need to update its package.json or typings.

Yomguithereal commented 1 year ago

@shahzod418 is this backward-compatible with older TypeScript versions? Shouldn't we keep both the types root key as well as adding one within exports?

shahzod-davlatov commented 1 year ago

@Yomguithereal Checked in my project with Typescript versions 3.8.2 and 1.0.0 and was getting the same error. I can add both there and there. Should I do it?

Yomguithereal commented 1 year ago

Should I do it?

If it does not break anything to have both, yes I think we should do so as a precaution.

shahzod-davlatov commented 1 year ago

@Yomguithereal Done

Yomguithereal commented 1 year ago

Will merge and release thanks.

Yomguithereal commented 1 year ago

@shahzod418 now released on npm as 0.25.3