search

graphp / algorithms

Common mathematical graph algorithms implemented in PHP
MIT License
135 stars 68 forks source link

[WIP] Add simple cycles algorithm #33

Closed phyrwork closed 1 year ago

phyrwork commented 5 years ago

Depends on #26

Test cases for

phyrwork commented 5 years ago

Do not merge! This implementation is buggy. I will update the PR at some point.

jp928 commented 4 years ago

@phyrwork Do you mind to share what is the bug you mentioned? I wish I could help.

clue commented 4 years ago

@phyrwork Thank you for filing this PR and for your patience! :+1: This PR is currently marked as WIP, are you planning to update this again?

I'd first like to get a maintenance release out to bring this library up to date before introducing any additional algorithms. Once this is done, I'm looking forward to merging more of these algorithms, so I hope you're still interested in getting this merged then :shipit:

Again thank you for your valuable contribution! I understand this long wait time can be frustrating, so rest assured I'll try to get these intermediary release out as soon as time permits (this project doesn't currently get any sponsoring, so this happens mostly in my spare free time) and will then look into this PR again in more depth! :+1:

SimonFrings commented 1 year ago

This ticket got automatically closed after renaming the master branch to 0.9.x. We're not sure of the exact reason for this, it seems like it had nothing to do with the fact to merge this PR into the old master branch, other tickets with the same situation were left untouched.

This pull request is open for quite a while now and didn't receive any updates since, this is why I suggest we leave this closed for now. If this topic is still relevant and needs some further investigation, we can always reopen it in the future and take another look :+1: