search

graphprotocol / docs

Documentation for The Graph
https://thegraph.com/docs
Apache License 2.0
81 stars 145 forks source link

set `proseWrap: 'always'` in prettier config to respect printWidth in markdown #303

Open dimaMachina opened 1 year ago

benface commented 1 year ago

If I remember correctly, we set proseWrap to never because wrapping introduced issues with the Crowdin segmentation... but that might not be a problem anymore. That said, it also makes diffs nicer when modifying the start or middle of a paragraph.

dimaMachina commented 1 year ago

That said, it also makes diffs nicer when modifying the start or middle of a paragraph.

exactly!

benface commented 1 year ago

Wait, I mean proseWrap: never does. 😅

dimaMachina commented 1 year ago

anyway it is up to you to decide, we use proseWrap: 'always' in our shareable configs and we love it, especially while reading markdown content in Macbook 13

benface commented 1 year ago

I personally use the "word wrap" feature of VS Code when working with text/markdown files that aren't wrapped (Cmd+Z shortcut), so it's not really a problem. But I'm open to changing it, we just have to make sure that it doesn't break Crowdin. Maybe we can start with one file, just to test?

dimaMachina commented 1 year ago

sure! we can try 👍