graphprotocol / docs

Documentation for The Graph
https://thegraph.com/docs
Apache License 2.0
81 stars 142 forks source link

substreams modules top level page broken #398

Closed saihaj closed 9 months ago

saihaj commented 1 year ago

Clicking on CleanShot 2023-06-01 at 11 31 00@2xthis page https://thegraph.com/docs/en/substreams/concepts-and-fundamentals/modules/

should take to https://substreams.streamingfast.io/developers-guide/modules

but shows a 403

reported: https://discord.com/channels/438038660412342282/989236488560607262/1113846308067881053

dimaMachina commented 1 year ago

https://github.com/graphprotocol/docs/blob/eea1e4d1e8bdd9f6e47547071299c10215138e92/website/pages/en/substreams/_meta.js#L19 I filtered this page because I remember it was empty

dimaMachina commented 1 year ago

@saihaj how this page looks like

image

We should remove/modify links that point to this route ?

saihaj commented 1 year ago

@saihaj how this page looks like

image

We should remove/modify links that point to this route ?

If you look the the gitbook docs link that page seems not to be empty

dimaMachina commented 1 year ago

@saihaj still empty 🥲 here source code https://raw.githubusercontent.com/streamingfast/substreams/develop/docs/developers-guide/modules/README.md

I think gitbook autogenerate content based on routes

saihaj commented 1 year ago

@saihaj still empty 🥲 here source code

https://raw.githubusercontent.com/streamingfast/substreams/develop/docs/developers-guide/modules/README.md

I think gitbook autogenerate content based on routes

That my makes it complicated now. If we remove then we need to think what happens to the links

dimaMachina commented 1 year ago

I can create a page with cards like in https://nextra.site/docs/guide or similar component from e&n design system

dimaMachina commented 1 year ago

or just remove the route from gitbooks too! and all links that points there to overcomplicated things

dimaMachina commented 1 year ago

or add redirect to another route https://thegraph.com/docs/en/substreams/developers-guide/overview/?

saihaj commented 1 year ago

I can create a page with cards like in https://nextra.site/docs/guide or similar component from e&n design system

Maybe we should create this but we would need an automatic way to figure out how these work 🤔 thoughts @benface

dimaMachina commented 1 year ago

I think redirecting to substreams’ https://thegraph.com/docs/en/substreams/developers-guide/overview page will be simplest way

benface commented 1 year ago

Rather, it should redirect to https://thegraph.com/docs/en/substreams/developers-guide/modules/types/, which is the first sub-page of the Developers Guide > Modules section, no?

KevinEOSNation commented 1 year ago

Currently the link is going to https://thegraph.com/docs/en/substreams/concepts-and-fundamentals/modules/

@benface suggested it link to this instead: https://thegraph.com/docs/en/substreams/developers-guide/modules/types/

Either way, it's not a broken link anymore. Any further action required?

benface commented 1 year ago

@KevinEOSNation – It is still a broken link (403): https://thegraph.com/docs/en/substreams/developers-guide/modules/

It's not clear from @saihaj's OP, but he was referring to the link at the bottom of the https://thegraph.com/docs/en/substreams/concepts-and-fundamentals/modules page, and not to that page itself.

KevinEOSNation commented 1 year ago

Ah...thank you for the clarification.

KevinEOSNation commented 9 months ago

Recommend closing this. SF has revamped its docs and these links now live on https://substreams.streamingfast.io/

@saihaj

benface commented 9 months ago

Agreed, closing.