graphprotocol / graph-network-subgraph

The subgraph, the smart contracts, the tests, and documents for the Graph Explorer Decentralized Application
MIT License
70 stars 45 forks source link

`indexer{allocations}` doesn't list all allocations (confusing naming) #271

Closed aasseman closed 4 months ago

aasseman commented 4 months ago

Observed on https://api.thegraph.com/subgraphs/name/graphprotocol/graph-network-arbitrum-sepolia

I would expect those 2 queries to yield the same results:

aasseman commented 4 months ago

Actually not a bug, just a confusing pattern

Would make more sense to have totalAllocations -> allocations and allocations -> activeAllocations here https://github.com/graphprotocol/graph-network-subgraph/blob/7247a4c075982fd49517adadbfcd9d6ce088f958/schema.graphql#L686-L690