Closed davekaj closed 3 years ago
Needs review from @Ariel @brandon @Jannis @nena @yanivtal
I made a PR with the full schema diffed, so we can comment on it right in the code
Adding some notes: Query time calculations that are not included in the schema, since they are calculated at query time:
Things I have not included
Adding some open questions:
Channel
as is, or name it Allocation
. I think channel is more representative of what it is within the code, but calling it the Allocation might be easier for readers to understand.I see there are network parameters in the GraphNetwork entity. How do we update those attributes if we change any of those in the contract? We could emit a ParameterUpdated(<name>)
if needed. Let me know.
As a heads up, I changed the distributor attributor in Curation to staking.
I see there are network parameters in the GraphNetwork entity. How do we update those attributes if we change any of those in the contract? We could emit a
ParameterUpdated(<name>)
if needed. Let me know.
Yeah in general I think we will likely have to have an event emit when any parameter has been updated
Agree with Ariel, regarding fees being the best proxy for work performed in the network.
Still confused on how GNS will work with the Subgraph type (parents and children, are we using this still?) Are we still using SubgraphType (commons vs owned).
We may revisit this sometime down the road, but for now we're opting for a much simpler flat naming system which we inherit from Github, ENS, Everest, etc. (starting with Github). For internal beta, the plan was to just have users enter their name without validation, but I think we should start thinking about the schema beyond internal beta (whether in this PR or another one I don't have strong opinions).
Agreed with query fee being best proxy.
But the front end designs have query count as a display value... so I am wondering how this will be obtained? Subgraph seems a natural fit, but that would mean we would have to publish this on chain too
This issue will be used to propose a schema. I will start off by making the first iteration, then I will bring people in on the team to discuss. We will decide in here and finalize an internal beta schema so we can all move forward in a coordinated fashion :)