[Bug] deployment_sync_secs metrics still emitted for synced subgraphs

brianluong commented 11 months ago

Bug report

We're still seeing deployment_sync_secs metrics still emitted for synced subgraphs on v0.31.0.

Specifically, we're still seeing these metrics emitted only when the indexer starts up.

I think this PR was intended to solve this in v0.31.0, but it doesn't seem it fully addresses the issue.

Relevant log output

No response

IPFS hash

No response

Subgraph name or link to explorer

No response

Some information to help us out

[ ] Tick this box if this bug is caused by a regression found in the latest release.
[ ] Tick this box if this bug is specific to the hosted service.
[X] I have searched the issue tracker to make sure this issue is not a duplicate.

OS information

None

lutter commented 11 months ago

When graph-node starts up, it assumes all subgraphs are not synced; once it processes a block, it determines whether the subgraph is synced and then turns off recording the metric. Depending on how long graph-node was shut down, it can take a bit of time for it to catch up to the chain head. During that time, it will record deployment_sync_secs.

Is that causing an issue for you?

brianluong commented 11 months ago

We noticed deployment_sync_secs for synced subgraphs was a significant contributor to our metrics usage.

To us (and maybe others) deployment_sync_secs are only interesting until the subgraph has synced.

github-actions[bot] commented 5 months ago

Looks like this issue has been open for 6 months with no activity. Is it still relevant? If not, please remember to close it.

graphprotocol / graph-node