search

graphprotocol / graph-node

Graph Node indexes data from blockchains such as Ethereum and serves it over GraphQL
https://thegraph.com
Apache License 2.0
2.92k stars 982 forks source link

improving response for `index-node` subgraph features API #5127

Open saihaj opened 10 months ago

saihaj commented 10 months ago

I think it is built in assumption that if you give an ID of subgraph you will get result back. But in the case where we cannot find that ID it just throws.

So we can either consider making index-node API that field be non-null or we have union of responses where we can define the error message of NotFound https://blog.logrocket.com/handling-graphql-errors-like-a-champ-with-unions-and-interfaces/

image

saihaj commented 10 months ago

related https://github.com/graphprotocol/indexer/issues/809

github-actions[bot] commented 3 months ago

Looks like this issue has been open for 6 months with no activity. Is it still relevant? If not, please remember to close it.