search

graphprotocol / graph-node

Graph Node indexes data from blockchains such as Ethereum and serves it over GraphQL
https://thegraph.com
Apache License 2.0
2.89k stars 961 forks source link

[Bug] Change subgraph runner tests to not graft onto subgraph head #5197

Open lutter opened 7 months ago

lutter commented 7 months ago

Some of the subgraph runner tests graft directly onto the subgraph head. PR #5135 made that very verboten, which would make those tests fail. For expediency, the PR just disables the check that we graft at least reorg_threshold blocks back for debug builds.

The right fix for this would be to change the subgraph runner tests to set a small reorg threshold and to graft only outside that reorg threshold so that the check can be enabled for debug builds, too.

github-actions[bot] commented 4 weeks ago

Looks like this issue has been open for 6 months with no activity. Is it still relevant? If not, please remember to close it.