search

graphprotocol / indexer-rs

Rewrite of indexer-service in Rust with TAP payments implementation
Apache License 2.0
22 stars 20 forks source link

Use hardcoded Tap Domain Separator from tap-core #115

Closed gusinacio closed 3 weeks ago

gusinacio commented 9 months ago

tap-core has a tap_eip712_domain function that uses the hardcoded name and version. We had some problems in the past with mismatch between those, let's just use this function.

https://docs.rs/tap_core/latest/tap_core/fn.tap_eip712_domain.html

gusinacio commented 9 months ago

We could move the DOMAIN_SEPARATOR to tap-core to prevent mismatches on any side.

YashBit commented 1 month ago

@gusinacio Please can you assign this to me?

gusinacio commented 1 month ago

@YashBit just assigned to you. Also added some description.